On Feb 13, 10:01 am, Ben Fritz <[email protected]> wrote:
>
> Maybe Vim can automatically add this ^ character somehow? This seems
> like a job for shellescape().
>
> As far as the patch is concerned, I still think it the right thing to
> do. But we must ask, which is more likely to occur in a call to an
> external program? The '&' character in an argument, or space
> characters in the command path and argument?- Hide quoted text -
>

Note in the original example:

let command = 'openssl dgst -binary -sha1 -hmac "A&B" < c:/temp/
foo.tmp'
let ret = system(command)

If this had been something like:

let command = '"C:\Program Files\OSSL\openssl" dgst -binary -sha1 -
hmac "A & B"'
let ret = system(command)

Then there is currently NO setting of shellxquote and shellcmdflag
that should work.

Does anybody see a problem with adding quoting of & with ^ in
shellescape? Some experimentation concerns me that things will break
if the user explicitly sets shellxquote back to empty, but if we
always use shellxquote=\" it will probably be OK:

U:\>echo "A^&B"
"A^&B"

U:\>cmd /c echo "A^&B"
"A^&B"

U:\>cmd /s /c "echo "A^&B""
"A&B"

U:\>cmd /c "echo "A^&B""
"A&B"

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

Raspunde prin e-mail lui