On Sat, Mar 17, 2012 at 07:09:00PM +0100, Bram Moolenaar wrote:
>
> Patch 7.3.475
> Problem: In a terminal with few colors the omnicomplete menu may be hard to
> see when using the default colors.
> Solution: Use more explicit colors. (suggested by Alex Henrie)
> Files: src/syntax.c
>
>
> *** ../vim-7.3.474/src/syntax.c 2012-01-10 22:26:12.000000000 +0100
> --- src/syntax.c 2012-03-16 20:14:22.000000000 +0100
> ***************
> *** 6645,6654 ****
> "SpellLocal term=underline ctermbg=Cyan guisp=Cyan gui=undercurl"),
> #endif
> #ifdef FEAT_INS_EXPAND
> ! CENT("Pmenu ctermbg=Magenta",
> ! "Pmenu ctermbg=Magenta guibg=Magenta"),
> ! CENT("PmenuSel ctermbg=DarkGrey",
> ! "PmenuSel ctermbg=DarkGrey guibg=DarkGrey"),
> #endif
> CENT("Title term=bold ctermfg=LightMagenta",
> "Title term=bold ctermfg=LightMagenta gui=bold guifg=Magenta"),
> --- 6645,6656 ----
> "SpellLocal term=underline ctermbg=Cyan guisp=Cyan gui=undercurl"),
> #endif
> #ifdef FEAT_INS_EXPAND
> ! CENT("PmenuThumb ctermbg=White",
> ! "PmenuThumb ctermbg=White guibg=White"),
> ! CENT("Pmenu ctermbg=Magenta ctermfg=Black",
> ! "Pmenu ctermbg=Magenta ctermfg=Black guibg=Magenta"),
> ! CENT("PmenuSel ctermbg=DarkGrey ctermfg=Black",
> ! "PmenuSel ctermbg=DarkGrey ctermfg=Black guibg=DarkGrey"),
> #endif
> CENT("Title term=bold ctermfg=LightMagenta",
> "Title term=bold ctermfg=LightMagenta gui=bold guifg=Magenta"),When the terminal supports fewer than 16 colors, this choice of colors for &background=dark results in PmenuSel having ctermbg=0 and ctermfg=0. This means the user can't read the selection. As noted in the help, NR-8 for DarkGrey is "0*" and * doesn't change anything for ctermbg. The attached patch switches ctermbg and ctermfg for PmenuSel. -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <[email protected]>
diff --git a/src/syntax.c b/src/syntax.c
--- a/src/syntax.c
+++ b/src/syntax.c
@@ -6653,8 +6653,8 @@
"PmenuThumb ctermbg=White guibg=White"),
CENT("Pmenu ctermbg=Magenta ctermfg=Black",
"Pmenu ctermbg=Magenta ctermfg=Black guibg=Magenta"),
- CENT("PmenuSel ctermbg=DarkGrey ctermfg=Black",
- "PmenuSel ctermbg=DarkGrey ctermfg=Black guibg=DarkGrey"),
+ CENT("PmenuSel ctermbg=Black ctermfg=DarkGrey",
+ "PmenuSel ctermbg=Black ctermfg=DarkGrey guibg=DarkGrey"),
#endif
CENT("Title term=bold ctermfg=LightMagenta",
"Title term=bold ctermfg=LightMagenta gui=bold guifg=Magenta"),
signature.asc
Description: Digital signature
