Christ van Willegen wrote: > my first 'real' patch, please bear with me. I hope I got the hg > command (hg diff) right to get a correct patch file... > > Attached patch adds the '-Y' command line switch. It is followed by > the name of the file holding a list of files to edit. This makes it > easier to edit files with 'strange' characters in the file name (glob > patters, spaces). It does _not_ make it easier to edit files with a > newline in the file name, sorry :-) > > Note that the file list is interpreted literally, so no glob expansion > of the file names in the list... > > Is there anything I should do to make the patch clearer? > > The only thing I am unsure about is the while loop taking out \n/\r > from the end of the file name... is this the way it should be done?
The diff looks fine. Before anything, please write the help file entries. This should make clear how the -Y argument interacts with other file names. How about the "-" argument (read stdin)? The new code looks quite long, there must be an easier way to do this. At least it should be moved to a separate function. This switch is much too long already. -- hundred-and-one symptoms of being an internet addict: 132. You come back and check this list every half-hour. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
