Simon Ruderich wrote: > On Thu, Sep 06, 2012 at 10:36:46PM +0200, Bram Moolenaar wrote: >> Yes, it would be nice to keep this consistent. virtcol() also returns 1 >> for the first column. > > Updated patch with adapted screencol()/screenrow(), updated > testcase (needs Dominique's patch applied) and documentation > attached. > > I hope that's enough to get Dominique's patch into Vim.
Thanks Simon for the patch! Some remarks: - It's better to send the patch as attachment because long lines were messed up by mail somehow. - I manually fixed the long lines in patch and it applied. But I saw a warning: Hunk #1 succeeded at 1902 with fuzz 2 (offset -1 lines). The patch was probably not made against the latest Vim in Mercurial. - declaration of screen_screencol() and screen_screenrow() were missing in src/proto/screen.c.pro, so when compiling, I saw warnings: screen.c:10260:1: warning: no previous prototype for ‘screen_screencol’ [-Wmissing-prototypes] screen.c:10269:1: warning: no previous prototype for ‘screen_screenrow’ [-Wmissing-prototypes] - in ":help screenrow()" I noticed a repeated word in: "screen row of *the the* cursor I attach a patch against Vim-7.3.659 which: - addresses all above minor issues - combine my original patch with your tests in one single patch for convenience. Regards PS: worth noticing that instead of... nnoremap <expr> GG ":echom ".screencol()."\n" ... we can also use: nnoremap <silent> GG :echom screencol()<CR> -- Dominique -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
fix-conceal-alignment-7.3.659.patch
Description: Binary data
