so8res wrote:

> With this patch you can do the following:
> 
>     syntax match Foo 'foo'
>     highlight Foo cterm=bold ctermfg=red
>     highlight Foo cterm+italic
> 
> and now Foo is both bold and italic.
> 
> Motivation:
> 
> http://stackoverflow.com/questions/13640538/vim-syntax-files-add-to-cterm
> 
> This makes it far easier to use terminal attributes on nested syntax
> regions, e.g. to add bold to text that is already underlined without
> losing the color.
> 
> The patch also allows terminal attributes to be removed.

I like the idea, but I would prefer to use += and -=, just like :set.

Also, can you write a test for correct behavior?

The documentation should mention what happens when trying to remove a
value that isn't there.  Is it a warning, error, or ignored?

The error for unexpected plus sign should be put in a function instead
of writing that code several times.


-- 
I AM THANKFUL...
...for the taxes that I pay because it means that I am employed.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

Raspunde prin e-mail lui