On Fri, Feb 1, 2013 at 7:18 PM, Nazri Ramliy <[email protected]> wrote: > The patch do not include Christian's fix for the problem > reported by François Ingelrest.
Attached is the updated (and less buggy) toy patch that include Christian's fix and test89, and also test90 for testing the new option 'linenumber'. What the patch does is mirror the options 'number' and 'relativenumber' into a single option 'linenumber', which is a string option. To avoid expensive strcmps when checking for the value 'linenumber' when drawing the line numbers I mirror it using an integer option 'linenumberstyle' (w_p_lnrsty). On one hand the patch simplifies tests like this: i = (wp->w_p_nu || wp->w_p_rnu) ? number_width(wp) : 0; to: i = (wp->w_p_lnrsty != LNR_NONE) ? number_width(wp) : 0; but on the other hand it seems to complicate things by having multiple variables representing the same stuff :-/ Hence I'm still calling it a toy patch. Nazri -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
lnr.diff
Description: Binary data
