On Fri, Apr 5, 2013 at 5:43 PM, Bram Moolenaar <[email protected]> wrote:
>
> Patch 7.3.879
> Problem:    When using an ex command in operator pending mode, using Esc to
>             abort the command still executes the operator. (David Bürgin)
> Solution:   Clear the operator when the ex command fails. (Christian Brabandt)
> Files:      src/normal.c

I don't know if you saw it but I posted an improved version of this
patch -- or so I thought.

https://groups.google.com/d/msg/vim_dev/rHP4zUKwp2g/y3qVRwRktHMJ

I pointed to two flaws in the current patch:

- There is a redundant call to clearop() when cancelling ordinary colon
  commands, e.g. ":call <Esc>".
- When cmd_result == FAIL and did_emsg == TRUE only clearop() will be
  called when instead clearopbeep() is the intended call. To be sure,
  currently this only happens when there's an out of memory error in
  ex_docmd.c#1055, but it's still not ideal.

Valid points or am I missing something?

I'm just asking out of curiosity and out of an interest to learn more.

Thanks.

David Bürgin

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Raspunde prin e-mail lui