No, wrong patch. The fact that module has attribute does not mean you do not need to check for the errors when obtaining it.
This one I posted in another thread, it uses common python EAFP principle. # HG changeset patch # User ZyX <[email protected]> # Date 1370228411 -14400 # Mon Jun 03 07:00:11 2013 +0400 # Branch python-extended-4 # Node ID 08aaf194681a293aac74b3c394fd1c8de166912c # Parent aeb6697bc6851e894681f9baad6ea9dc808c6714 Clear the error in case fchdir is missing diff -r aeb6697bc685 -r 08aaf194681a src/if_py_both.h --- a/src/if_py_both.h Sun Jun 02 06:58:33 2013 +0400 +++ b/src/if_py_both.h Mon Jun 03 07:00:11 2013 +0400 @@ -5447,6 +5447,8 @@ if (PyObject_SetAttrString(os, "fchdir", get_attr(m, "fchdir"))) return -1; } + else + PyErr_Clear(); return 0; } -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
