On Monday, June 3, 2013 9:29:03 AM UTC+2, mattn wrote: > On Monday, June 3, 2013 7:33:39 AM UTC+9, Christian Wellenbrock wrote: > > > I recently noticed the following inconsistency regarding the 'fillchars' > > and 'statusline options: > > > > > > > > > > > > - multi-byte 'fillchars' work with default 'statusline': > > > > > > vim -u NONE -c "set ls=2 fcs=stl:●" > > > > > > [No Name] [+]●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●● > > > > > > > > > > > > - single-byte 'fillchars' work with custom 'statusline': > > > > > > vim -u NONE -c "set ls=2 fcs=stl:x stl=a%=b" > > > > > > axxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxb > > > > > > > > > > > > - multi-byte 'fillchars' with custom 'statusline' fall back to '-': > > > > > > vim -u NONE -c "set ls=2 fcs=stl:● stl=a%=b" > > > > > > a---------------------------------------------b > > > > > > > > > > > > I attached a patch that yields the following statusline for the last > > invocation: > > > > > > a●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●b > > > > > > > > > > > > This is my first vim contribution. Some questions I asked myself in the > > process: > > > > > > > > > > > > 1. Is it ok to introduce a local variable here or should it be inlined > > instead? > > > > > > 2. Would on big #if-#else-block be preferable to those two smaller ones? > > > > > > 3. Should I check `has_mbyte` in the #if-#else-blocks? > > > > > > > > > > > > Thank you, > > > > > > Christian > > > > > > I don't make sure this patch. This patch seems not modified screen.c, Is this > support double width characters? > > > > Thanks.
Yes, this patch does not modify screen.c, because screen.c is already capable of handling multi-byte characters, as you can see in the first of my three examples. I have not tried using it with double width characters. The original intent was to support single width multi-byte characters. I don't know if double width character support is as easy to implement. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
