Re: Python os.chdir() patch

[Ken Takata]

Hi,

2013/06/03 Mon 21:01:27 UTC+9 Ken Takata wrote:
> There is still another problem on Windows.
> The following commands cause a crash:
> 
> :py import vim
> :py vim.fchdir()
> 
> I think NULL check of _chdir is needed in _VimChdir(),
> or vim.fchdir should be undefined on Windows.

Attached patch at least fixes the crash.
But I still think vim.fchdir should be removed on Windows.

Thanks,
Ken Takata

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



# HG changeset patch
# Parent 7e19cc676a2e9c44ecee4dc97e8bbe750142c977
diff --git a/src/if_py_both.h b/src/if_py_both.h
--- a/src/if_py_both.h
+++ b/src/if_py_both.h
@@ -718,6 +718,8 @@
     PyObject	*todecref;
     char_u	*new_dir;
 
+    if (!_chdir)
+	return NULL;
     if (!(r = PyObject_Call(_chdir, args, kwargs)))
 	return NULL;