Hi Ben! On 2013-06-06 Thursday at 07:27 -0700 Ben Fritz wrote: > On Thursday, June 6, 2013 3:08:24 AM UTC-5, Roland Eggner wrote: > > … … > > I reported not clearly enough, I am afraid. There are 2 probably related > > bugs: > > > > (1) Commit “7.3.880 Problem: When writing viminfo, old history lines may > > replace lines written more recently by another Vim instance. Solution: > > Mark > > history entries that were read from viminfo and overwrite them when merging > > with > > the current viminfo.” turned the viminfo feature effectively to a > > “vimforget” > > feature. The patch provided below reverts this. > > Certainly not the best solution. > > The patch may have broken :wviminfo, but the normal method of writing and > reading viminfo (on Vim enter and exit) is much more useful after the patch.
May I assume, your certainty is based on a test of my patch in a setup following the description I provided together with the patch? What particular shortcomings did you encounter? > Before the patch, it was too easy to lose history when launching multiple Vim > instances. You read in my previous mail, by which simple setup you could rule out this case, did you? For the impatient: shortest possible summary of bug (1) and my bugfix: ----------------------------------------------------------------------- Prior to commit 7.3.880, in some corner cases some history entries have been lost. After commit 7.3.880 _all_ history entries predating the previous session are _always_ lost. Using my patch and the setup explained in the patch description _all_ history entries are _always_ kept, until the history size limit set by option “history” is hit. Even in corner cases (e.g. multiple vim instances, power failures …), _less_ history entries are lost, than with pristine vim-7.3.969 and default setup. -- Regards Roland Eggner
pgpMCFW4rCnPL.pgp
Description: PGP signature
