----- Original Message ----- > From: "Bram Moolenaar" <[email protected]> > > Rob Owens wrote: > > > I made a dumb newbie error on my diff files, so I'm sending the > > updated ones. This time I used the vim files from mercurial > > instead > > of Debian's versions (headsmack!) > > > > Syntax files are attached. For filetype.vim and synmenu.vim, see > > the > > diffs below. > > The names of the syntax files contain an underscore. No other syntax > file has that. I think it's better to keep it consistent: > > upstream_dat.vim -> upstreamdat.vim > upstream_install_log.vim -> upstreaminstalllog.vim > upstream_log.vim -> upstreamlog.vim > usserver_log.vim -> usserverlog.vim > usw2kagt_log.vim -> usw2kagtlog.vim >
That would be fine. I'll make the change. > Perhaps the names can be made shorter without losing meaning? I'm not sure if I can make them shorter without causing confusion. Is this critical? The names come from the names of our log files. Because the log files often get renamed by users, they may need to manually enable the syntax highlighting with :set syntax=upstreamlog That's why I'd prefer meaningful over short when it comes to names. > The syntax files need to have header, see other syntax files for > examples. OK > All items in the syntax file need to start with the name of the > syntax > file. I see the following format used: fileName But I also see this: file_name (in dosbatch.vim, for example). I'll assume the first example is preferred unless you tell me otherwise. > Use "hi def link" instead of "hi link". OK. > Please have a look at a few other syntax files to see the usual > structure. Thanks for all the advice. Hopefully I'll have time next week to get these fixed up and re-submitted. -Rob -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
