On Tue, June 18, 2013 22:10, Bram Moolenaar wrote:
>> Attached is an updated patch, implementing your suggestions, as well as
>> a hit '?' to show a help banner.
>>
>> Bram, if this gets merged, I think it makes sense to also merge the 'u'
>> flag for undo the last substitution (that I have posted a while ago).
>
> Do they interfere?  It's always better to keep change separate if
> possible, so that when one of them causes trouble we can revert it.

Ok. I just meant, when you are including that one patch, you might also
include the other, since both enhance the confirmation dialog for
:s command.

>
>>      {
>>      sub_nsubs = 0;
>>      sub_nlines = 0;
>> +    global_do_ask = TRUE;
>
> This name is a bit confusing, since it doesn't actually switch on
> asking.  How about global_stop_asking?  It's set to FALSE at the start
> and end of :global, when A or Q is typed then it's set to TRUE.

Here is an updated patch.

regards,
Christian

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Attachment: global_subst_confirm_msg.diff
Description: Binary data

Raspunde prin e-mail lui