> > Bundles solve exactly one problem: they avoid problems with applying > > patches. They do introduce another problem: now it is tricky to see the > > diff (any discussion around PR’s assumes having web interface for them). >
> No, the discussion only assumes that everyone can see the same changes. It's > easy enough to get the changes into a personal clone on your system to view > them. That is an early step in merging and applying them anyway. I assume any > changes merged in from pull requests must be tested before publishing. Before pulling into my clone I normally view diff to check out that it is worth pulling at all. Some problems do not need pulling to be discovered. > > With bundles one still needs to repost each time he has an update (common > > for emailed bundles and diff). > > I view that as a good thing. You'll need to post anyway when you make an > update, otherwise nobody knows about it unless they are following your > repository very closely. If Bram has 12 pull requests, he probably won't want > to monitor each repository to see if anything changes. So the pull requester > must post to say "updated to fix XYZ". If the changes are immediately > available in the email, the maintainer has less work left to do to get them. ?! You don’t need to post, you need to push to a proper branch and it will appear in PR automatically. AFAIR github does not bother notifying in this case, dunno about bitbucket, but it would be good thing to do (I mean, notify about push into PR). > That said, I'd probably prefer to just pull from a public repository myself, > if I knew the correct revision to pull in. Github mails you with a correct command to pull. Anybody here has an experience with bitbucket regarding pull requests? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
