cac2s wrote:
> > So, do you want some arbitrary user be able to undo the changes that
> > root has made? Those are root's changes, in my opinion only root should
> > be able to do anything with these changes. Also, we probably don't want
> > any other user than root being able to see what changes were made, thus
> > the owner of the undo file must be set to the user who made the changes.
> >
> > In case the same user edits the file again, then it does make sense to
> > use the undo file. So perhaps we can allow reading the undo file if
> > it's owned by the current user, even when this differs from the owner of
> > the file?
>
> I think in case the undo file is in same directory as the file being
> edited, checking who is the owner of the undo file should be done, to
> prevent security problems.
>
> but if all undo files are in the root's home folder, then this check
> may be omitted since root only has access to the /root
>
> as an option, you can add a param which will disable the comparing of
> ownership of the undo files, if you specified the directory for them
> (set undodir=...)
>
> how do you like that kind of logic?
I do not see how the directory of the undo file matters. Unless we also
check the ownership of that directory. But that can get complicated.
I also don't like making a special case for root, except when it's to
stay on the safe side. E.g., root changing someone else's may cause the
original owner to lose undo, since the undo file ownership changed.
That's OK, because the owner should not be able to use root's changes.
But root should be able to undo his own changes, which is what my patch
intends to accomplish.
--
hundred-and-one symptoms of being an internet addict:
182. You may not know what is happening in the world, but you know
every bit of net-gossip there is.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
