On Nov 8, 2013 1:16 AM, "Bram Moolenaar" <[email protected]> wrote:
>
>
> Christian Brabandt wrote:
>
> > On Thu, November 7, 2013 03:26, Bram Moolenaar wrote:
> > > Thanks. Are you scared of the number 100? :-)
> >
> > kind of. The more tests we add, the harder it is to find one, that can
> > be used for adding more tests. So I figured, it would make sense, to
> > give them more meaningful names, so one can make an educated guess
> > from the name what they are about.
> >
> > Plus, it prevents name clashes and allows to easier handle local
> > patches. I have a bunch of local patches laying around, that each
> > wants to add test100.in and .ok and once I go through my patch queue,
> > it gets more and more likely, that a patch can't be applied, because
> > of that.
>
> Yeah, names would be clearer. Although it's not so easy to come up with
> names, numbers are a lot simpler.
It is very easy if you think about it before writing a test. It would not
be so easy for existing ones though, especially monsters like test49.
> > BTW: is there a reason, not to make the Test Makefile use wildcard
> > expansion to find all relevant tests? (i.e. something like this:
> >
> > SCRIPTS = $(subst in,out,$(wildcard test*.in))
> >
> > Well, I just see, this would need a couple of more changes, to exclude
> > the test*a.in files, but should be reasonable, I think.
> > (Not sure if this is really workable on non GNU Systems).
>
> My experience with wildcards is that they often cause trouble. They may
> pick up too much or not work on older systems. We don't add tests often
> enough that it's a problem to edit the Makefiles.
>
> Keep in mind that these Makefiles have to work on just about any system.
> That's what makes it easy to run Vim on just about any Unix-like system.
> Not supporting certain implementations of make will cause serious
> problems for a small group of users.
I would rather solve this by adding a Makefile generator which will update
Makefiles and not by requiring contributors create changes for 100500
makefiles. This is inefficient. There is no need for generator to be
runnable all systems like we do not require autoconf to run make or
configure.
It is easy enough to write generator in POSIX shell making it runnable on
every system contributors actually use. This will also solve problems with
wildcards: wildcards will be placed in the generator and not in Makefiles.
>
> One thing that should be a portable solution is to put the list of test
> files in a separte Makefile that is included by others. However, that
> doesn't work for the Makefiles that skip a few that don't work on the
> specific system, such as VMS or MS-Windows.
There are :if !has(...) ... workarounds for this in some files. I do not
see why we should not use them for VMS or MS Windows since there are things
like has('vms').
>
> --
> TERRY GILLIAM PLAYED: PATSY (ARTHUR'S TRUSTY STEED), THE GREEN KNIGHT
> SOOTHSAYER, BRIDGEKEEPER, SIR GAWAIN (THE FIRST TO
BE
> KILLED BY THE RABBIT)
> "Monty Python and the Holy Grail" PYTHON (MONTY)
PICTURES LTD
>
> /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net
\\\
> /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/\\\
> \\\ an exciting new programming language -- http://www.Zimbu.org
///
> \\\ help me help AIDS victims -- http://ICCF-Holland.org
///
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
"vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
> For more options, visit https://groups.google.com/groups/opt_out.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
