Cesar Romani wrote: > On 06/12/2013 03:03 p.m., Bram Moolenaar wrote: > > > > Cesar Romani wrote: > > [...] > > > >> ifeq (yes, $(DYNAMIC_PERL)) > >> DEFINES += -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl$(PERL_VER).dll\" > >> +EXTRA_LIBS += -L$(PERL)/lib/CORE -lperl$(PERL_VER) > >> else > >> EXTRA_LIBS += $(PERL)/lib/CORE/perl$(PERL_VER).lib > >> endif > > > > Although this addition looks OK, does it work for older Perl versions? > > If not, what condition should be put around the new line? > > > > I used it with Perl 5.16 and there wasn't any problem. > > >> @@ -688,8 +688,7 @@ > >> $(CC) $(CFLAGS) -o uninstal.exe uninstal.c $(LIB) > >> > >> $(TARGET): $(OUTDIR) $(OBJ) > >> - $(CC) $(CFLAGS) $(LFLAGS) -o $@ $(OBJ) $(LIB) -lole32 -luuid > >> $(LUA_LIB) $(MZSCHEME_LIBDIR) $(MZSCHEME_LIB) $(PYTHONLIB) $(PYTHON3LIB) > >> $(RUBYLIB) > >> - > >> + $(CC) $(CFLAGS) $(LFLAGS) -o $@ $(OBJ) $(LIB) -lole32 -luuid > >> $(LUA_LIB) $(MZSCHEME_LIBDIR) $(MZSCHEME_LIB) $(PYTHONLIB) $(PYTHON3LIB) > >> $(RUBYLIB) -L$(PERLLIBS) -lperl$(PERL_VER) > >> upx: exes > >> upx gvim.exe > >> upx vim.exe > > > > This isn't right, it will fail when compiling without Perl. > > Look around line 635. > > > > How about with this one: > > -------------------- > --- Make_ming.mak.org 2013-11-22 00:16:21 -0500 > +++ Make_ming.mak 2013-12-06 21:21:05 -0500 > @@ -380,6 +380,7 @@ > CFLAGS += -I$(PERLLIBS) -DFEAT_PERL -L$(PERLLIBS) > ifeq (yes, $(DYNAMIC_PERL)) > CFLAGS += -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl$(PERL_VER).dll\" > +EXTRA_LIBS += -L$(PERLLIBS) -lperl$(PERL_VER) > endif > endif
Hmm, adding -L$(PERLLIBS) to CFLAGS seems fishy. Perhaps it should be like this: ifdef PERL CFLAGS += -I$(PERLLIBS) -DFEAT_PERL ifeq (yes, $(DYNAMIC_PERL)) CFLAGS += -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl$(PERL_VER).dll\" EXTRA_LIBS += -L$(PERLLIBS) -lperl$(PERL_VER) else EXTRA_LIBS += -L$(PERLLIBS) endif endif However, if the -L argument comes too late this might not work. Or perhaps the -L argument isn't needed? > @@ -688,8 +689,7 @@ > $(CC) $(CFLAGS) -o uninstal.exe uninstal.c $(LIB) > > $(TARGET): $(OUTDIR) $(OBJ) > - $(CC) $(CFLAGS) $(LFLAGS) -o $@ $(OBJ) $(LIB) -lole32 -luuid > $(LUA_LIB) $(MZSCHEME_LIBDIR) $(MZSCHEME_LIB) $(PYTHONLIB) $(PYTHON3LIB) > $(RUBYLIB) > - > + $(CC) $(CFLAGS) $(LFLAGS) -o $@ $(OBJ) $(LIB) -lole32 -luuid > $(LUA_LIB) $(MZSCHEME_LIBDIR) $(MZSCHEME_LIB) $(PYTHONLIB) $(PYTHON3LIB) > $(RUBYLIB) $(EXTRA_LIBS) > upx: exes > upx gvim.exe > upx vim.exe > -------------------- -- How To Keep A Healthy Level Of Insanity: 10. Ask people what sex they are. Laugh hysterically after they answer. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
