On 14-Jan-2014 José Bollo <[email protected]> wrote:
> On mar, 2014-01-14 at 15:20 +0100, Christian Brabandt wrote:
> > On Tue, January 14, 2014 14:41, José Bollo wrote:
> > > Hi all,
> > > I'm working for Tizen that uses the Linux Security Module SMACK.
> > >
> > > Then, I wrote a patch to vi to make the copy of the smack attributes.
> > >
> > > What is the process to push it mainstream?
> >
> > You mean vim, right?
>
> yes!
>
> > If so, then simply publish it here (by attaching
> > it to a mail).
>
> See attachment. Not really sure to be up-to-date. Let me know, I'm
> staying tuned.
>
> Best regards
> José
Some comments:
1. You are not following the Vim coding convention everywhere: opening and
closing braces on their own lines.
2. How about following this approach:
vim_snprintf(lbuf, BUFSIZ, _(" line=%ld id=%d name=%s"),
(long)p->lnum, p->id,
sign_typenr2name(p->typenr));
MSG_PUTS(lbuf);
instead of:
+ MSG_PUTS(_("\nCould not set security context "));
+ MSG_PUTS(name);
+ MSG_PUTS(_(" for "));
i.e. so that there's "Could not set security context %s for " string to
translate instead of two shorter strings? Why start it with "\n" btw?
3.
+ MSG_PUTS(_("\nCould not remote security context "));
s/remote/remove/
--
Lech Lorens
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
