Hi, For some systems where the smack library is not used (e.g. Mac OS X), the configure script resulting from Patch 7.4.238 can yield *console* messages wrong in both format and semantics, while the configured variables used for building vim appear to be all correctly set.
Actually, on Mac, when —disable-smack was not given to the configure script as an argument, I got checking --disable-smack argument... checking linux/xattr.h usability... no checking linux/xattr.h presence... no checking for linux/xattr.h... no yes The points are: (1) The reply to ‘checking —disable-smack argument’ was intervened by the xattr.h checks. (2) The value of the reply should be ‘no’ because —disable-smack was not given to the script. I think the correct form should look like checking --disable-smack argument... no checking linux/xattr.h usability... no checking linux/xattr.h presence... no checking for linux/xattr.h… no Hopefully, the tiny patch attached with this email fixes those issues. Regards, Kazunobu Kuriyama
On Apr 2, 2014, at 21:06, Bram Moolenaar <[email protected]> wrote: > > Patch 7.4.238 > Problem: Vim does not support the smack library. > Solution: Add smack support (Jose Bollo) > Files: src/config.h.in, src/configure.in, src/fileio.c, > src/memfile.c, > src/os_unix.c, src/undo.c, src/auto/configure > <snip> > *** ../vim-7.4.237/src/configure.in 2014-03-27 18:51:06.604760919 +0100 > --- src/configure.in 2014-04-02 13:49:36.955901004 +0200 > *************** > *** 387,406 **** > AC_SUBST(QUOTESED) > > > ! dnl Link with -lselinux for SELinux stuff; if not found > ! AC_MSG_CHECKING(--disable-selinux argument) > ! AC_ARG_ENABLE(selinux, > ! [ --disable-selinux Don't check for SELinux support.], > ! , enable_selinux="yes") > ! if test "$enable_selinux" = "yes"; then > AC_MSG_RESULT(no) > ! AC_CHECK_LIB(selinux, is_selinux_enabled, > ! [LIBS="$LIBS -lselinux" > ! AC_DEFINE(HAVE_SELINUX)]) > else > AC_MSG_RESULT(yes) > fi > > dnl Check user requested features. > > AC_MSG_CHECKING(--with-features argument) > --- 387,427 ---- > AC_SUBST(QUOTESED) > > > ! dnl Link with -lsmack for Smack stuff; if not found > ! AC_MSG_CHECKING(--disable-smack argument) > ! AC_ARG_ENABLE(smack, > ! [ --disable-smack Do not check for Smack support.], > ! , enable_smack="yes") > ! if test "$enable_smack" = "yes"; then > ! AC_CHECK_HEADER([linux/xattr.h], true, enable_smack="no") > ! fi > ! if test "$enable_smack" = "yes"; then > AC_MSG_RESULT(no) > ! AC_CHECK_LIB(attr, llistxattr, > ! [LIBS="$LIBS -lattr" > ! found_smack="yes" > ! AC_DEFINE(HAVE_SMACK)]) > else > AC_MSG_RESULT(yes) > fi > > + dnl When smack was found don't search for SELinux > + if test "x$found_smack" = "x"; then > + dnl Link with -lselinux for SELinux stuff; if not found > + AC_MSG_CHECKING(--disable-selinux argument) > + AC_ARG_ENABLE(selinux, > + [ --disable-selinux Do not check for SELinux support.], > + , enable_selinux="yes") > + if test "$enable_selinux" = "yes"; then > + AC_MSG_RESULT(no) > + AC_CHECK_LIB(selinux, is_selinux_enabled, > + [LIBS="$LIBS -lselinux" > + AC_DEFINE(HAVE_SELINUX)]) > + else > + AC_MSG_RESULT(yes) > + fi > + fi > + > dnl Check user requested features. <snip>
configure.in.patch
Description: Binary data
-- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
