Andy Russell wrote: > Hello everyone, > > I am a user of the fish shell (http://fishshell.com/). However, the > "system" function in Vim currently uses subshell syntax which is > incompatible with fish. This forces fish users to set their shell to > /bin/bash as a workaround. I have attached a patch that uses the fish > syntax if Vim detects a user's shell as fish. > > Note that this patch also refactors code that detects the name of a > user's shell into a function "get_isolated_shell_name()" to avoid code > duplication between option.c and ex_cmds.c. > > I'm looking forward to a review.
Thanks, looks good. The fnamecmp() is repeated, I'll change that a bit. I'll include it. -- hundred-and-one symptoms of being an internet addict: 118. You are on a first-name basis with your ISP's staff. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
