Alexey Radkov wrote: > Here is some small improvements for the patch: > > src/window.c, match_add(): > - removed unnecessary (after alloc() to alloc_clear() transformation) > zero-initializations of m->pos fields, > - checking that li == NULL was moved inside for-loop body > - decrement i when the pos_list element is a number and has value 0 to be > symmetric with sublist counterpart > > src/screen.c: > - simple code alignment > > runtime/doc/eval.txt, matchaddpos(): > this is a bit more important: actually column number and match length must > correspond to bytes as col() returns, not screen columns as virtcol() > returns! It does matter for Unicode texts like Cyrillics, i changed doc to > reflect this.
Thanks. Now that we have one working test, perhaps you can add a few more tests? Would be good if we cover the alternatives in the code. -- Proverb: A nightingale that forgets the lyrics is a hummingbird. /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
