Ben Fritz wrote:
> > > The attached patch seems to fix the crash reported here:
> > >
> > > https://groups.google.com/d/topic/vim_dev/Nr8Ja4Zjghw/discussion
> > >
> > >
> >
> >
> > Thanks for making this patch!
> >
> > Did you run the tests under valgrind? That's a very good way to check
> > for any memory access problems and leaks. Instructions are in
> > src/testdir/Makefile. There are a few false positives, compare to a Vim
> > without your patch.
> >
>
> You're welcome! I'm seeing crashes from time to time at work when Vim
> isn't really actively doing much of anything, so I figured this stood
> some chance of being the cause.
>
> I have not checked in valgrind, because I've never used it before, and I
> developed the patch on Windows. I do have a Ubuntu dual-boot, I'll try
> logging in and seeing how well I can follow the instructions in the
> makefile later this week. Thanks for pointing them out!
>
> Do you have input on the 3 questions I had about aborting the collection
> when malloc fails?
>
> 1. Does there need to be any user notification of the aborted garbage
> collection?
I think it would be useful to do this when 'verbose' is non-zero.
Or perhaps when 'debug' contains "msg". In case a user wonders if he is
suffering from aborted garbage collection he can use the setting to find
out if that is the case.
> 2. Do I need to set any of the garbage collect flags when aborting
> collection due to failure in the setup?
Not sure. We want to avoid that the GC runs over and over, so perhaps
do reset the flag that GC is needed.
> 3. How to get a return value from LUA interface, to allow aborting if it
> fails?
I hope someone else answers that.
--
GUARD #1: Where'd you get the coconut?
ARTHUR: We found them.
GUARD #1: Found them? In Mercea? The coconut's tropical!
ARTHUR: What do you mean?
GUARD #1: Well, this is a temperate zone.
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
