On 22/07/14 14:27, Bram Moolenaar wrote:

Tony wrote:

On 22/07/14 10:57, Bram Moolenaar wrote:

Arkadiusz Miśkiewicz wrote:

Could someone fix 7.4.356  patch that sits on vim ftp? It tries to patch
.hgignore file which doesn't exist in released tarballs.

OK, let's do the same as for the other patch that changes .hgignore.

Thanks!

ps. would be nice to enhance whatever script creates these patches to avoid
this mistake in future since it is not the first time it happens

Well, only the second time.  It's not so easy to automate.


Would it be so hard to identify and remove any patch for a file whose
name starts with, let's say, .hg (dot-aich-gee)? Or should we watch out
for other "special" files?

You don't want to drop the patch but only remove the part that changes
the .hgignore file.

Maybe I spoke unclearly; I didn't mean drop the whole diff file but the part (one or more hunks) concerning .hgignore, and possibly any other .hg* if present in the same diff. If "ordinary" files (Makefile, *.mak, configure.in, configure, *.c, *.cpp, *.h, if_perl.xs, *.vim, *.txt, *.po, *.in, *.ok, etc.) are patched at the same time, of course we keep those parts, as I said below.


Of course if there are other files patched in the same diff, they should
be kept; and if there is no change at all to version.c (and thus no
patch number) I suppose the whole changeset can be omitted from the FTP
server — or can it?

Not sure, depends on what script you use to patch.

Myself, I don't (I rely on the Mercurial server), but I'm trying to look at the question from the POV of those who do. In the past, "runtime-files-only" changes were omitted from the FTP server, though individual runtime file changes were sometimes found there together with related changes to the code.


Anyway, I rely on people to tell me about things that don't work and
then fix them.  In practice it doesn't happen very often.


:-)


Best regards,
Tony.
--
"I have come to believe that the whole world is an enigma, a
 harmless enigma that is made terrible by our own mad attempt
 to interpret it as though it had an underlying truth."
                   [Umberto Eco]

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui