Hello group, I posted a patch "[patch] allow NSIS installer to install Vim in a directory with a name not ending with "Vim" " on September 24, but it was neither applied nor rejected. Bram either did not get my last messages or ignored them. Could somebody please help me get this patch applied? Maybe a review and opinion of an expert Vim developer could help? Or what would you suggest to do in this situation?
here is the full discussion (https://groups.google.com/forum/#!searchin/vim_dev/nsis/vim_dev/hOajm7CBW_4/4otuvw6-QeQJ ): Thank You --Tim ========================================================================== Sep 24: Hello, the NSIS installer expects the installation directory to end with "Vim", which is not always possible or desired (e.g. "Vim huge"). This patch removes this restriction. diff -r 187798e5e4b5 nsis/gvim.nsi --- a/nsis/gvim.nsi Tue Sep 23 21:53:41 2014 +0200 +++ b/nsis/gvim.nsi Wed Sep 24 23:50:57 2014 +0200 @@ -1,6 +1,5 @@ # NSIS file to create a self-installing exe for Vim. # It requires NSIS version 2.0 or later. -# Last Change: 2010 Jul 30 # WARNING: if you make changes to this script, look out for $0 to be valid, # because uninstall deletes most files in $0. @@ -38,7 +37,7 @@ RequestExecutionLevel highest ComponentText "This will install Vim ${VER_MAJOR}.${VER_MINOR} on your computer." -DirText "Choose a directory to install Vim (must end in 'vim')" +DirText "Choose a directory to install Vim" Icon icons\vim_16c.ico # NSIS2 uses a different strategy with six different images in a strip... #EnabledBitmap icons\enabled.bmp @@ -132,14 +131,10 @@ NoCancelAbort: FunctionEnd -# We only accept the directory if it ends in "vim". Using .onVerifyInstDir has +# Using .onVerifyInstDir has # the disadvantage that the browse dialog is difficult to use. Function CheckInstallDir StrCpy $0 $INSTDIR 3 -3 - StrCmp $0 "vim" PathGood - MessageBox MB_OK "The path must end in 'vim'." - Abort - PathGood: FunctionEnd Function .onInstSuccess On Sun, Sep 28, 2014 at 2:37 PM, Tim Lebedkov <[email protected]> wrote: > On Sat, Sep 27, 2014 at 9:57 PM, Bram Moolenaar <[email protected]> wrote: >> >> Tim Lebedkov wrote: >> >>> the NSIS installer expects the installation directory to end with >>> "Vim", which is not always possible or desired (e.g. "Vim huge"). This >>> patch removes this restriction. >> >> I believe the main problem is that when installing a new version, Vim >> won't find the old version. Would it be possible to ask for >> confirmation that the user really intended to install in a different >> directory? >> >> Perhaps it's sufficient to check that the path contains "vim" in the >> last part of the path? >> >> >> -- >> hundred-and-one symptoms of being an internet addict: >> 192. Your boss asks you to "go fer" coffee and you come up with 235 FTP >> sites. >> >> /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ >> /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ >> \\\ an exciting new programming language -- http://www.Zimbu.org /// >> \\\ help me help AIDS victims -- http://ICCF-Holland.org /// > > > Hello Bram, > > uninstall_check() in dosinst.c actually scans the registry for keys > that start with "Vim" and extracts the directory from the path to the > uninstaller. This means that the name of the installation directory > may be arbitrary. Hello Bram, what is the status of this patch? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
