Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 272 by [email protected]: Allow NSIS installer to install Vim
in a directory with a name not ending with "Vim"
https://code.google.com/p/vim/issues/detail?id=272
What steps will reproduce the problem?
1. start the Windows installer
2. choose as installation directory one named "Vim huge"
What is the expected output? What do you see instead?
The expected output would be a normal Vim installation, an error message is
shown instead.
What version of the product are you using? On what operating system?
7.4, Windows 7 64 bit
Please provide any additional information below.
Here is the proposed patch:
diff -r 187798e5e4b5 nsis/gvim.nsi
--- a/nsis/gvim.nsi Tue Sep 23 21:53:41 2014 +0200
+++ b/nsis/gvim.nsi Wed Sep 24 23:50:57 2014 +0200
@@ -1,6 +1,5 @@
# NSIS file to create a self-installing exe for Vim.
# It requires NSIS version 2.0 or later.
-# Last Change: 2010 Jul 30
# WARNING: if you make changes to this script, look out for $0 to be valid,
# because uninstall deletes most files in $0.
@@ -38,7 +37,7 @@
RequestExecutionLevel highest
ComponentText "This will install Vim ${VER_MAJOR}.${VER_MINOR} on your
computer."
-DirText "Choose a directory to install Vim (must end in 'vim')"
+DirText "Choose a directory to install Vim"
Icon icons\vim_16c.ico
# NSIS2 uses a different strategy with six different images in a strip...
#EnabledBitmap icons\enabled.bmp
@@ -132,14 +131,10 @@
NoCancelAbort:
FunctionEnd
-# We only accept the directory if it ends in "vim".
Using .onVerifyInstDir has
+# Using .onVerifyInstDir has
# the disadvantage that the browse dialog is difficult to use.
Function CheckInstallDir
StrCpy $0 $INSTDIR 3 -3
- StrCmp $0 "vim" PathGood
- MessageBox MB_OK "The path must end in 'vim'."
- Abort
- PathGood:
FunctionEnd
Function .onInstSuccess
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
