Comment #4 on issue 287 by [email protected]: Newline substitution
behaviour
https://code.google.com/p/vim/issues/detail?id=287
I've got some issues with that patch:
- I don't like modifying eap content (can have undesirable side-effects
down the road).
- Edge case of single-line-range in last-line-of-file still calls do_join,
with count == 1. This should be better avoided, IMO, because:
1) do_join precondition states it should be called with count >= 2.
2) if called with count == 1, it does nothing useful anyway, so it can be
saved.
- Reported subsitutions/lines are still wrong. If you join n lines, you
should report n - 1 substitutions in n - 1 lines.
I attach an alternative patch fixing all that.
Attachments:
issue_287_alt.patch 913 bytes
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
