Kazunobu Kuriyama wrote:
> On Jan 27, 2015, at 22:09, Bram Moolenaar <[email protected]> wrote:
>
> >
> > Patch 7.4.598
> > Problem: ":tabdo windo echo 'hi'" causes "* register not to be changed.
> > (Salman Halim)
> > Solution: Change how clip_did_set_selection is used and add
> > clipboard_needs_update and global_change_count. (Christian
> > Brabandt)
> > Files: src/main.c, src/ui.c, src/testdir/test_eval.in,
> > src/testdir/test_eval.ok
>
> With this patch, test_eval is doomed to fail if vim under the test is
> not featured with clipboard (e.g., vim built with the configure
> options —with-features=normal and —with-gui=no).
Yeah, I noticed when running tests with different configurations.
> Attached are two patches to fix it.
>
> testdir.patch separates the clipboard test from the other tests of
> test_eval.in, by adding new test files called
> test_eval_clipboard.{in,ok} to the existing test files, so that vim,
> even if it is not featured with clipboard, will be tested against the
> existing tests that have been used prior to 7.4.598.
>
> Of course, with my patches, vim with clipboard will be fully tested as
> intended with Patch 7.4.598.
This will copy some functions to the other test file. I think we can
add a condition in test_eval. I'll have a go at that.
> Another tiny patch, ui.c.patch, suppresses the warnings about unused
> variables:
>
> ui.c:76:12: warning: unused variable 'clipboard_needs_update'
> [-Wunused-variable]
> static int clipboard_needs_update; /* clipboard needs to be updated */
> ^
> ui.c:77:12: warning: unused variable 'global_change_count' [-Wunused-variable]
> static int global_change_count = 0; /* if set, inside a start_global_changes
> */
We can move them inside the other #ifdef.
> As I wrote previously, I’m not an expert of vim test system. So, I’m
> quite open to revising my patches. Even more, I utterly welcome
> someone writes better ones :-)
--
There are three kinds of persons: Those who can count and those who can't.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
