On Saturday, February 7, 2015 at 10:39:05 PM UTC+9, Bram Moolenaar wrote: > Itchyny wrote: > > > The option 'incsearch' just jumps to the first matching place and > > highlights it. > > We then press enter, all the matches are get highlighted (if we set > > hlsearch on). > > If Vim highlights all the matching strings, it would be nice. > > > > There's already an implementation in Vim script > > (https://github.com/haya14busa/incsearch.vim). > > However, this plugin uses its own command-line like interface thus > > very limited and the code is too complicated. > > > > If this feature will be implemented with a small patch, it would be > > nice and I hope it merged. > > > > Here's a simple patch I wrote. > > I noticed that just removing the SEARCH_KEEP flag enables Vimt to > > highlight the > > matches while searching (search.c:L1149, ex_getln.c:L1795). > > Of course, as you notice, the following patch overwrites the default > > behavior > > and it must be fixed if the feature will be merged to Vim. > > Does anyone get interested in implementing the followings? > > - new option ('incsearchhlall' or something like that)to highlight > > all the matches > > while searching (disabled by default) > > - related documents and helps > > We need different highlighting for the matches other than the one that > the cursor would jump to. If that's different enough then I don't think > we need yet-another-option. At least for me the search highlighting and > the incsearch match highlighting are very different. > > > -- > hundred-and-one symptoms of being an internet addict: > 191. You rate eating establishments not by the quality of the food, > but by the availability of electrical outlets for your PowerBook. > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Thank you, Bram and Ben. However, Bram, I do not understand what you mean -- they are different _then_ you don't think we need yet-another-option. I now understand that highlighting all the matches and incsearch are different, _therefore_ we need another option to enable highlighting all the matches while searching, right? Of course the highlighting color should be different from both of Search and IncSearch. Considering the reputation the existing plugin (https://github.com/haya14busa/incsearch.vim while the plugin name might be misleading) got, it is apparent that many people want the feature implemented in Vim. (I again state that the existing plugin uses many dirty hacks (own cmdline-like interface and getchar() loops) to implement the feature) itchyny -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
