James McCoy wrote:
> On Fri, Jun 12, 2015 at 10:50:47PM +0200, Christian Brabandt wrote:
> > On Fr, 12 Jun 2015, Bram Moolenaar wrote:
> > > Christian wrote:
> > > > So I think, it makes sense to have \U in a quoted string also accept up
> > > > to 8 characters.
> > > >
> > > > So here is a patch.
> > >
> > > Thanks.
> >
> > To be fair, I think I should mention, that this could break existing
> > scripts.
>
> I see this sort of conjecture tossed around periodically and figured I'd
> see what sort of impact this change would actually have.
>
> Using github-backup[0], I cloned the (automatically created) git
> repos[1] for all 5092 scripts hosted on vim.org. Searching all of those
> repos for the pattern \\U\d\{5,} only turned up results in 6 .vim files.
> All of those were in single-quoted strings which were being used to
> piece together a larger regex for yaml parsing, which means none of them
> would be affected.
>
> While I'm sure there's are script authors that don't post their scripts
> on vim.org, that's a pretty good sample size with no hits.
>
> Just for good measure, I also searched[2] all the .vim files that exist
> in Debian and there were no matches.
>
> [0]: https://joeyh.name/code/github-backup/
> [1]: https://github.com/vim-scripts
> [2]:
> https://codesearch.debian.net/results/%5C%5CU%5Cd%7B5%2C%7D%20path%3A.*%5C.vim/page_0
Thanks for doing that! We do often wonder if a change would break
existing scripts and sometimes have to come up with another solution.
Having actual numbers helps a lot.
In this case it appears it's safe to move forward.
--
>From "know your smileys":
:-| :-| Deja' vu!
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
