Hi, On Mon, Jun 29, 2015 at 2:32 PM, Florian Walch <[email protected]> wrote: > On Monday, June 29, 2015 at 12:40:28 PM UTC+3, Drew Neil wrote: >> I finally got round to building Vim with the cdo.diff patch and I'm >> currently test-driving it. >> >> First thing I tried was populating the quickfix list using :Ggrep (a wrapper >> for git-grep supplied by the fugitive.vim plugin). Then I made a change to >> every line in the quickfix list: >> >> :cdo normal A -- it works! >> >> Then I updated each of the files listed in the quickfix list: >> >> :cfdo update >> >> Both commands worked as expected. >> >> I did notice one oddity: after running :cdo, the syntax highlighting is >> disabled for each file listed in the quickfix list with the exception of the >> last file, which has syntax highlighting enabled. The documentation says >> that disabling syntax highlighting gives a performance boost, which is good >> to know. My guess is that syntax highlighting is supposed to be re-enabled >> after running :cdo, but there's some bug that causes it to be re-enabled >> only for the last file in the list. I have observed similar behaviour when >> using the :argdo command, so perhaps this bug (if it is a bug) is out of >> scope for this particular patch. >> >> These are my initial observations. I'll keep on using my build with the >> cdo.diff patch and report back with any further findings. >> >> Thanks, >> Drew >> >> >> On Monday, April 6, 2015 at 6:41:10 PM UTC+1, [email protected] wrote: >> > Hi all, >> > >> > On Mon, Apr 6, 2015 at 6:58 AM, Drew Neil <[email protected]> wrote: >> > > On Sunday, March 22, 2015 at 2:43:22 AM UTC, [email protected] wrote: >> > >> Hi all, >> > >> >> > >> On Sun, Jun 2, 2013 at 2:09 PM, Bram Moolenaar wrote: >> > >> > >> > >> > Yegappan Lakshmanan wrote: >> > >> > >> > >> >> I am attaching a patch to add the :cdo and :ldo commands. The :cdo >> > >> >> command >> > >> >> can be used to execute commands over all the buffers in the quickfix >> > >> >> list. >> > >> >> The :ldo command can be used to execute commands over all the >> > >> >> buffers in >> > >> >> the location list. These are similar to the existing :bufdo, :windo >> > >> >> and :tabdo commands. >> > >> > >> > >> > Thanks. I'll add it in the todo list. >> > >> > >> > >> >> > >> I am attaching an updated patch with a lot of test cases against Vim >> > >> 7.4.671. >> > >> This patch introduces the ":cdo", ":ldo", ":cfdo" and ":lfdo"commands. >> > >> The patch to the documentation is also included. >> > > >> > > Nice work Yegappan. I would love to see these features included in Vim. >> > > >> > >> > It looks like a lot of people are interested in this feature. It will >> > help if people >> > can apply this patch and try the new commands and give some feedback. >> > >> > Thanks, >> > Yegappan > > I ported the patch to Neovim [1], where CI discovered that it causes test10 > to fail. I tested against Vim 7.4.764, and test10 fails there as well (see > [2]). > > Cheers, > Florian > > [1] https://github.com/neovim/neovim/pull/2927 > [2] https://travis-ci.org/fwalch/vim-ci/builds/68879635 >
I have an updated patch that already fixes this problem and a few other warnings found by clang. I have also added the proper range handling for these commands. I will send out the updated patch in a few days. - Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
