Charles Campbell wrote:
> Daniel Hahler wrote:
> > When there is a `kdeinit4` process, but `kfmclient` is not installed
> > `BrowseX` fails to open an URL (it falls through to the last else block).
> >
> > This happened on a non-KDE system, where `kdeinit4` was
> > installed/started for an unknown reason, but konqueror/kfmclient is not
> > available.
> >
> > This patch also makes the `system()` call only when necessary (via a
> > function), and will prefer `xdg-open` unconditionally also for potential
> > KDE systems.
> >
> > After all, `xdg-open` is better aware of the current desktop environment
> > and is designed for use cases like this.
> >
> > The old code was primarily meant to handle edge cases when `gnome-open` was
> > used.
> > I have left it as a fallback in case `xdg-open` might not be available.
> >
> > The patch is available in a branch at:
> > https://github.com/blueyed/vim/compare/fix-netrw-with-kdeinit (which
> > includes a commit to fix trailing whitespace).
> >
> > I am attaching the patch from the main commit
> > (https://github.com/blueyed/vim/commit/b5e13acebc11c13290d3f3dd9940b1ab181f47a3).
> >
> Thanks! I'll look into it.
There has been an update to netrw (version 153), but it still looks for a
running "kdeinit" to detect a KDE system (which is currently the case for me
for whatever reason), but then has the following code still in netrw#BrowseX:
elseif has("unix") && executable("xdg-open") && !s:CheckIfKde()
...
elseif has("unix") && executable("kfmclient") && s:CheckIfKde()
...
Therefore this still causes netrw#BrowseX to do nothing in this case:
s:CheckIfKde() is true (which skips xdg-open), but "kfmclient" is not installed.
Please recondider / include the part from my patch that uses "xdg-open"
unconditionally:
https://github.com/vim-jp/vim/commit/b5e13acebc11c13290d3f3dd9940b1ab181f47a3
Thanks,
Daniel.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
