Gary Johnson wrote: > On 2015-08-04, Bram Moolenaar wrote: > > Justin M. Keyes wrote: > > > > > On Aug 3, 2015 17:08, "Gary Johnson" wrote: > > > > > > > > When a file of fewer lines than the window height is diffed against > > > > a longer file, the shorter file's ruler shows only "Bot" when all > > > > the lines are displayed. It should show "All". > > > > > > > > As an example, start Vim like this. > > > > > > > > $ vimdiff -N -u NONE --cmd 'set ruler' <(seq 21 30) <(seq 50) > > > > > > > > The cursor will be at the first line of the left window and the > > > > ruler will show "Top". Move the cursor to the last line of the left > > > > buffer. The ruler will now show "Bot" even though the entire buffer > > > > is visible in the window. > > > > > > > > It seems to me that the ruler should show "All" and that this is a > > > > bug. > > > > > > > > > > I agree, this makes it hard to know whether one has viewed all changed > > > lines. > > > > It doesn't say "All" because there are filler lines above, these also > > matter. If you don't see the filler lines you don't know what is > > missing there that's in the other file. > > They matter, but that is not the apparent purpose of the > "Top/Bot/%/All" indicator in the ruler. As ":help 'ruler'" says, > "Top [indicates that the] first line is visible" and "All [indicates > that the] first and last lines are visible". > > > Perhaps we could consider showing one filler line sufficient, no > > need to see all of them? > > In a side-by-side display, we need to see a filler line for each > line present in the other buffer but absent in the current buffer, > just as it is now. > > I can see that there are filler lines above the first line of text > in the window. The problem is that I can't tell whether there are > any common lines above the filler lines I see. > > If I am looking at a window in diff mode that looks like this: > > ---------------------------------------- > ---------------------------------------- > ---------------------------------------- > ---------------------------------------- > ---------------------------------------- > Lorem ipsum dolor sit amet, consectetur > tempus, porttitor urna vitae, bibendum t > maximus bibendum. Donec tincidunt ultric > velit. Aliquam luctus gravida libero, eu > Pellentesque pharetra euismod nisl. Cura > 5,1 Bot > > it's obvious that the other buffer has lines preceding the ones in > this buffer. What's not obvious is whether there are more common > lines above those shown. The only way to find out, other than doing > math on the cursor position and the lines shown, is to try to move > the cursor above the first text line in this buffer. It should be > sufficient to glance at the ruler and see "Top" or "All".
Yeah, thus seeing one filler line means you have seen everything that there is to see, thus we can consider that "All". Showing "All" without that one filler line is a bit strange to me, there is still some information missing. -- Not too long ago, a program was something you watched on TV... /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
