So, guys, what do you finally think about this patch? Both cursorcolumn and colorcolumn in wrapped texts with multiple conceals may look just unperfect without it. So I would be glad to see the patch in the main vim code base and feel relaxed about this :)
Cheers, Alexey. 2015-07-14 5:14 GMT+03:00 Alexey Radkov <[email protected]>: > Hi Dominique. > > The situation this patch tries to fix appears when there are conceals > _and_ cuc or colorcolumn is wrapped. I can reproduce it with the vim > command you provided for the help files by narrowing the window width (no > matter terminal or GUI) and scrolling lines up and down with cursor at the > end of string and cuc set (i.e. cuc must be wrapped!). See the image > attached. (I am sorry for this image spam!) > > The situation gets worse when there are intense conceals scattered here > and there. I am using plugin vim-pandoc-syntax ( > https://github.com/vim-pandoc/vim-pandoc-syntax) for editing markdown > files (see images from my previous examples). It makes use of conceals to > emphasize pieces of text. I am not sure if there is a standard markdown > viewer for vim that can conceal emphasized text ..., but anyway, as another > example, you can set up vim-pandoc-syntax for viewing md files (or just > type :set ft=pandoc after opening) and open vim's README.md on github: > > vim 'https://raw.githubusercontent.com/vim/vim/master/README.md' > > Then wrap cuc/cursorcolumn and you'll see how bad these misaligned columns > may look. With the patch applied the columns will look aligned. > > Cheers, Alexey. > > > 2015-07-14 2:18 GMT+03:00 Dominique Pellé <[email protected]>: > >> Alexey Radkov <[email protected]> wrote: >> >> > Hi Dominique. >> > >> > Thank you for testing this. The patch was missing a simple test in the >> macro >> > FIX_FOR_BOGUSCOLS. I added that in a new patch attached: now it should >> work. >> > >> > Cheers. >> >> Thanks Alexey for the update. I've tried it. It's better now. >> So far I see no problems, but I will try it more and I did not >> have time to find a case where alignment was broken without >> your patch. So could you give a file and vim settings where >> the bug was happening without your patch? >> >> Thanks! >> Dominique >> > > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
