Markus Heidelberg wrote: > > > Maybe you can comment on some other items from the old mail as well. > > > > Can you repeat the relevant questions? > > Oh, not that many remaining which needed clarification. New comments by > myself compared to the old mail after "MH": > > * Unify name and mail for author and commiter, see: > $ git shortlog --email -s > > These should all be the same person for the current history. > > MH: In the latest git commits the mail is Bram@... (uppercase B), so > I'd use this.
I don't care too much. All of the commits are actually from me, right? That the mail address changes at some points, probably because of switching to some other system or script, isn't really relevant for someone looking at it. It's not like they have to find out who committed a change. > * Format commit messages to work properly with git commands for the log > summary, > e.g. "git shortlog" or "git log --oneline". The output of these commands is > ugly at the moment. > > That means adding a blank line after the first line and ideally using > a descriptive one-liner for the first line. This is the format > recommended for Git repositories. > > e.g. from this: > Patch 7.2.446 > Problem: Crash in GUI when closing the last window in a tabpage. > (ryo7000) > Solution: Remove the tabpage from the list before freeing the window. > > to this (from vim_mainline.git): > [7.2.446] Crash in GUI when closing the last window in a tabpage. > (ryo7000) > > Problem: Crash in GUI when closing the last window in a tabpage. > (ryo7000) > > Solution: Remove the tabpage from the list before freeing the window. > > Patch 7.2.446 > > There may be better conversions without duplicating the problem > description. > > MH: Probably we should discard this because it only makes sense if it > is continued in your scripts. I had tried different messages, and it's difficult to find one that works well. Just using the patch number is consistent at least, but doesn't give much information. Using the "Problem" line has the problem (eh) that it's truncated at some unpredictable place. Writing a short line, like we have it in the README file on the ftp server, would be an awful lot of work. > * Add the patch description for commits before 7.2.328 > Unfortunately these commit messages do not include the patch > description, this was from the conversion to HG. Has nothing to do > with migration to Git, but maybe the effort is worth it. > > MH: I have to see whether the effort is manageable. I think if someone wants to full history of patches, the ftp server is more useful. After all, in the early days the patches were the main thing, the repository just following that. And before that there was no repository. It's unlikely that someone needs to look back to before 7.4. So let's just have the patches on 7.4 look good. We are getting closer to August 25, so let's try to get this done this week. -- Life is a gift, living is an art. (Bram Moolenaar) /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
