Random, *disclaimer: I've not read the spec*
I was getting ready to take your side, but then I realized that reproducing the build already means specifying the build environment and command-line flags. Since there already must be a container for all command-line flags, I think you should add a command-line flag that enables reading the environment variable, and pass that around as part of the reproducible build. Then Bram's happy because it's not turned on by accident (no matter how unlikely that accident may seem), and you're happy because your system works as designed. Regards, Tofer On 12/11/15, Random832 <[email protected]> wrote: > On 2015-12-11, Bram Moolenaar <[email protected]> wrote: >> Sorry, I just do not agree with that spec. Building software using >> environment variables is brittle and is bound to go wrong. Environment >> variables can be set for various reasons, and there is hardly any >> control over them. Generally they are user preferences. > > Every environment variable that is set is there for a reason > (*someone* had to put it there, after all). I don't understand > why you think there's going to be a user preference called > SOURCE_DATE_EPOCH. Users don't put random names in their > environment, they put names that actually mean something to > programs that they use. > > Also, "generally they are user preferences" is a bit of a > stretch. My environment in a new shell window right now > consists of the following variables: > > USER SHLVL OLDPWD XDG_SESSION_COOKIE LOGNAME TERM PATH LANG PWD > EDITOR HOME MAIL SHELL SSH_CLIENT SSH_CONNECTION SSH_TTY TMUX > TMUX_PANE VISUAL XDG_RUNTIME_DIR XDG_SESSION_ID _ > > I think that of those, only VISUAL, EDITOR, and if you really > stretch the definition SHELL and PATH, are "user preferences". > > The problem with using command line arguments is that not every > build system uses the same command. > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
