On 16/12/2015 17:09, Mike Williams wrote:
On 16/12/2015 16:32, Christian Brabandt wrote:
Hi Mike!
For me it seems to be caused by patch 7.3.1141:
changeset: 4789:10673b3531eb
tag: v7.3.1141
user: Bram Moolenaar <[email protected]>
date: Fri Jun 07 19:17:14 2013 +0200
files: src/os_win32.c src/os_win32.h src/version.c
description:
updated for version 7.3.1141
Problem: Win32: Check for available memory is not reliable and adds
overhead.
Solution: Remove mch_avail_mem(). (Mike Williams)
Yeah, I saw that and got a sinking feeling. Double checked and got a
working build at the time and double checked. It did not fail for me
originally which is why it now feels very sensitive to memory layout in
any particular build. It may have been operator error.
I have checked 4789 with upped maxmem and it worked, and checked the
previous change - 4787 with reduced maxmem and that failed. So the
issue is interaction of maxmem with the example process for reproducing
the corruption. I would imagine this means the issue can be forced on
other systems as well and not just Windows.
While I don't know, if it is sensible to remove mch_avail_mem() on
windows, I believe this only triggers the bug, because when
HAVE_AVAIL_MEM is not set, vim internally sets the 'maxmem' and
'maxmemtot' options to much lower values and I think, high values of
those options just hide the bug.
The HAVE_AVAIL_MEM symbol controls two separate functions - setting of
maxmem/maxmemtot and altering the memory allocator. I removed it from
Windows for the reasons in the commit - it slows the allocator and isn't
accurate for how it was being used. However, it does throw out the
setting of maxmem/maxmemtot with it. The setting of maxmem/maxmemtot
should be under a separate control IMHO.
TTFN
Mike
--
But honey, I need a new Pentium server so I can reboot faster.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
