Hi Kazunobu!

On Fr, 05 Feb 2016, Kazunobu Kuriyama wrote:

> Hopefully, the attached patch fixes the compilation error.
> 
> That part of code causing the error is the code for GTK+ 3.14 and 3.15.
> 
> Port to GTK+ 3 requires care for such differences between minor versions (sigh
> :)
> 
> If you find anything wrong with the patch, please let me know.

I still see some compile warnings:

gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread 
-I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 
-I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include 
-I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo 
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 
-I/usr/include/libpng12 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -DGTK_DISABLE_SINGLE_INCLUDES 
-DUSE_GTK3   -g -DDEBUG -Wall -Wextra -Wshadow -Wmissing-prototypes 
-Wmaybe-uninitialized       -o objects/gui_gtk.o gui_gtk.c
gui_gtk.c:222:18: warning: ‘stock_vim_icons’ defined but not used 
[-Wunused-variable]
 static IconNames stock_vim_icons[] = {
                  ^
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread 
-I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 
-I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include 
-I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo 
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 
-I/usr/include/libpng12 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -DGTK_DISABLE_SINGLE_INCLUDES 
-DUSE_GTK3   -g -DDEBUG -Wall -Wextra -Wshadow -Wmissing-prototypes 
-Wmaybe-uninitialized       -o objects/gui_gtk_x11.o gui_gtk_x11.c
gui_gtk_x11.c: In function ‘gui_gtk_shift_lines’:
gui_gtk_x11.c:6866:15: warning: unused variable ‘y_src’ [-Wunused-variable]
     const int y_src  = FILL_Y(from);
               ^
gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread 
-I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 
-I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include 
-I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo 
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 
-I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 
-I/usr/include/libpng12 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -DGTK_DISABLE_SINGLE_INCLUDES 
-DUSE_GTK3   -g -DDEBUG -Wall -Wextra -Wshadow -Wmissing-prototypes 
-Wmaybe-uninitialized       -o objects/gui_gtk_f.o gui_gtk_f.c
gui_gtk_f.c: In function ‘gtk_form_size_request’:
gui_gtk_f.c:542:14: warning: variable ‘form’ set but not used 
[-Wunused-but-set-variable]
     GtkForm *form;
              ^
gui_gtk_f.c:541:12: warning: unused variable ‘tmp_list’ [-Wunused-variable]
     GList *tmp_list;
            ^


Also, starting the gui, I see this gtk warning:
(gvim:7782): Gtk-WARNING **: GtkNotebook 0x1d6f1e0 is mapped but visible 
child GtkEventBox 0x1b26280 is not mapped


Also there is the redrawing problem. Type something into the Command 
line:
:foobar foobar foobar

Do not press enter, but rather use backspace to delete the line. you will see
some white boxes, covering the line wherever the cursor was

Also tab completing anything in the commandline, won't clear the 
commandline afterwards.

Second, that gui tab looks strange there is almost no indication where a tab 
begins and ends
Is it supposed to be like that?

https://imgur.com/WGwMrgI

Yes and I still have lots of redrawing problems when scrolling. It gets 
a little bit better, when enable cursorline or using 'V' to select 
lines.

https://imgur.com/xEGhCsT
(this is just after closing the help window). Note the several cursor 
blocks, the not-cleared commandline and some text from the help window 
is still visible (the light yellow text).


Best,
Christian
-- 
Man braucht nicht immer denselben Standpunkt zu vertreten, denn
niemand kann einen daran hindern, klüger zu werden.
                -- Konrad Adenauer

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui