On Friday, February 19, 2016 at 6:58:48 AM UTC+9, Bram Moolenaar wrote:
> I don't quite get it.  Looking at the code, this ch_readraw() doesn't
> specify a callback for the one read, it specifies a new callback for the
> channel.  That's not what the user expects.  Better do something like:
> 
>       call ch_setoptions(channel, {"callback": "Callback"})
> 
> I find it unexpected that ch_readraw() doesn't actually read anything.
> 
> For ch_sendraw() and ch_sendexpr(), if a callback is specified the
> functions don't wait for a response and let that specific callback
> handle the response.  When using JS or JSON the sequence number can be
> used to know which response belongs to which request.  With RAW and NL
> we can only guess that the responses come in the same order as the
> requests.
> 
> Queing up callbacks for RAW and NL responses isn't implemented yet,
> perhaps that confused you.
> 
> This change seems to also support some other waiting for Win32, it's
> hard to see from the diff.  Perhaps you can adjust the patch for that,
> or move it to a new patch?

I updated patch.

https://gist.github.com/mattn/d6198b38d9b18edcb2aa

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui