Since I've got no response so far, I did $ git log -- if_sniff.c
and found that the file has been touched several times only for maintenance reasons --- either version updates or compiler warning suppression --- for more than a decade. It clearly indicates that the sniff interface is incredibly, extremely stable or just has had no user for years. Should we keep the interface? I feel dropping it eases the maintenance and paves the way for other useful features. 2016-02-24 22:21 GMT+09:00 Kazunobu Kuriyama <[email protected]>: > Hi, > > With the attached patch, gui_gtk_x11.c will compile with the sniff feature. > > But I'm not sure if it indeed enables the feature because I've never used > it, so I don't know what are proper checks. > > Could you, or someone else, please check if the patch enables the sniff > feature? > > Best regards, > Kazunobu Kuriyama > > 2016-02-24 21:17 GMT+09:00 Ismail Donmez <[email protected]>: > >> Hi, >> >> Using --with-gui=gtk3 ends up with: >> >> gui_gtk_x11.c:6471:5: error: unknown type name 'GdkInputCondition' >> GdkInputCondition condition UNUSED) >> ^ >> gui_gtk_x11.c: In function 'gui_mch_wait_for_chars': >> gui_gtk_x11.c:6503:6: warning: implicit declaration of function >> 'gdk_input_remove' [-Wimplicit-function-declaration] >> gdk_input_remove(sniff_input_id); >> ^ >> gui_gtk_x11.c:6509:19: warning: implicit declaration of function >> 'gdk_input_add' [-Wimplicit-function-declaration] >> sniff_input_id = gdk_input_add(fd_from_sniff, >> ^ >> gui_gtk_x11.c:6510:11: error: 'GDK_INPUT_READ' undeclared (first use in >> this function) >> GDK_INPUT_READ, sniff_request_cb, NULL); >> ^ >> gui_gtk_x11.c:6510:11: note: each undeclared identifier is reported only >> once for each function it appears in >> gui_gtk_x11.c:6510:27: error: 'sniff_request_cb' undeclared (first use in >> this function) >> GDK_INPUT_READ, sniff_request_cb, NULL); >> ^ >> Makefile:2760: recipe for target 'objects/gui_gtk_x11.o' failed >> >> >> -- >> -- >> You received this message from the "vim_dev" maillist. >> Do not top-post! Type your reply below the text you are replying to. >> For more information, visit http://www.vim.org/maillist.php >> >> --- >> You received this message because you are subscribed to the Google Groups >> "vim_dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
