Yukihiro Nakadaira wrote:
> > > On Wed, Feb 24, 2016 at 8:11 PM, mattn <[email protected]> wrote:
> > >
> > > > I'm thinking "kill" is not matter for this test because this test
> > should
> > > > be checking of exit.
> > > >
> > > > diff --git a/src/testdir/test_channel.vim
> > b/src/testdir/test_channel.vim
> > > > index 69922b1..e74e54c 100644
> > > > --- a/src/testdir/test_channel.vim
> > > > +++ b/src/testdir/test_channel.vim
> > > > @@ -483,6 +483,7 @@ func Test_exit_callback()
> > > > if has('job')
> > > > call s:run_server('s:test_exit_callback')
> > > >
> > > > + call job_stop(s:exit_job, "kill")
> > > > " the job may take a little while to exit
> > > > sleep 50m
> > > >
> > >
> > > In CUI Vim, job_stop(job, "hup") doesn't work because AttachConsole()
> > fails.
> > > The following patch might fix it. Job process is created in same
> > console.
> > > I'm not sure if it doesn't causes another problem.
> >
> > There is a todo item to make it possible to start a terminal for the job
> > to run in. This is especially useful if the job produces some output
> > and perhaps even prompts for input. We don't want that to get mixed up
> > with the Vim display.
> >
> > So hopefully we can make both work. This would require the job to be
> > started with a socket, so its stdin/stdout go to the terminal.
> >
>
> I see. So "kill" is a simple solution.
I'm wondering, if this test fails because the job didn't finish yet,
don't we have the same problem with every other test, since they all
start the server?
It seems that the default behavior for mch_stop_job() is being too
gentle. And it only has "kill" and everything else. And that means
sending CTRL_C_EVENT or CTRL_BREAK_EVENT.
Perhaps we should make the default behave like "kill" and only have
"hup" and "int" send an event? The default is actually supposed to be
the same as "term", which for MS-Windows probably is the same as "kill".
--
BROTHER MAYNARD: Armaments Chapter Two Verses Nine to Twenty One.
ANOTHER MONK: And St. Attila raised his hand grenade up on high saying "O
Lord bless this thy hand grenade that with it thou mayest
blow thine enemies to tiny bits, in thy mercy. "and the Lord
did grin and people did feast upon the lambs and sloths and
carp and anchovies and orang-utans and breakfast cereals and
fruit bats and...
BROTHER MAYNARD: Skip a bit brother ...
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
