I wrote:

> Christian Brabandt wrote:
> 
> > On Do, 25 Feb 2016, Bram Moolenaar wrote:
> > 
> > > 
> > > Patch 7.4.1421
> > > Problem:    May free a channel when a callback may need to be invoked.
> > > Solution:   Keep the channel when refcount is zero.
> > > Files:      src/eval.c, src/channel.c, src/proto/channel.pro
> > 
> > You probably already noticed, that this broke appveyor:
> > https://ci.appveyor.com/project/chrisbra/vim/build/729/job/fnvk0u5d9jip3xnr#L2316
> 
> I just noticed.  I suspect that we now don't close the channel when the
> job stops, in the case there is a handler.

Apparently we can't make a difference between a socket that closes
normally and a failure.  Let's remove the error message when reading
fails and only put it in the channel log.

-- 
There is no right or wrong, there is only your personal opinion.
                 (Bram Moolenaar)

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui