Unfortunately, I got the same experience that Manuel Ortega went through. Yesterday, I ran "make test" several times after pulling the patch into my repo, and didn't see any failure with it.
But today, I got it (FWIW, after pulling other new patches into the repo and building vim with them). The error message I got was the same as Manuel's: >From test_channel.vim: Found errors in Test_open_delay(): function Test_open_delay[3]..<SNR>3_run_server line 46: 'Caught exception: Vim(call):E631: ch_evalexpr(): write failed' TEST FAILURE As Bram suggested, I edited test_channel.vim to have the log file. But then the error was gone as Manuel described. The bug is really nasty. It usually behaves as if it were normal but suddenly hits unlucky guys. If someone tries to inspect it, it goes out of sight. I feel the patch should be revised or reverted. Best regards, Kazunobu Kuriyama 2016-03-01 5:06 GMT+09:00 Bram Moolenaar <[email protected]>: > > Manuel Ortega wrote: > > > > > I just build 7.4.1457 on OS X 10.11.3, and `make test` failed with > this > > > > error: > > > > > > > > From test_channel.vim: > > > > Found errors in Test_open_delay(): > > > > function Test_open_delay[3]..<SNR>3_run_server line 46: 'Caught > > > exception: > > > > Vim(call):E631: ch_evalexpr(): write failed' > > > > TEST FAILURE > > > > make[2]: *** [report] Error 1 > > > > make[1]: *** [test] Error 2 > > > > make: *** [test] Error 2 > > > > > > > > Let me know if I need to provide anything else. > > > > > > That is unfortunate. Did it still pass with 7.4.1456? Then it must be > > > the change to channel_open() that causes this. > > > > > > > It did pass with 7.4.1456. > > > > It might be useful to have the log. Edit src/testdir/test_channel.vim > > > and uncomment the ch_logfile() line (near the end). Then run the test > > > and see if you can relate the log with that test failure. > > > > > > I tried doing this, but then I couldn't reproduce the test failure. This > > is baffling, since I made sure I could get a test failure more than once > > (with `make distclean` in between) before I bothered to report it here. > > Strange. > > > Side note: After doing the suggested uncommenting, I found that running > > `make distclean` did NOT remove src/testdir/channellog. That should > > probably be fixed. Perhaps there are other test-related things that > `make > > distclean` is not deleting, and which cause problems. > > "make distclean" removes files that are normally created during > building. It doesn't delete core dumps, valgrind logs, etc. This log > file will not normally be produced, thus it's good that 'git status' > shows it, you know it's to be deleted. > > > I'll keep trying to reproduce the test failure, and if I can, I'll > > resurrect this thread. > > I had a try myself on a Macbook: tests passed. > > -- > A M00se once bit my sister ... > "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES > LTD > > /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net > \\\ > /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ > \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org > /// > \\\ help me help AIDS victims -- http://ICCF-Holland.org > /// > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
