Dominique wrote:
> I see compilation warnings when building vim-7.4.1493 with:
>
> $ ./configure --with-features=normal --enable-gui=none --enable-channel=no
> $ make
> ...
> $ gcc -c -I. -Iproto -DHAVE_CONFIG_H -g -O2 -Wall -Wextra
> -Wmissing-prototypes -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DU_DEBUG
> -DEXITFREE -o objects/os_unix.o os_unix.c
> os_unix.c: In function ‘mch_start_job’:
> os_unix.c:5040:50: warning: unused parameter ‘options’ [-Wunused-parameter]
> mch_start_job(char **argv, job_T *job, jobopt_T *options)
> ^
> os_unix.c:5136:5: warning: ‘fd_out[1]’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> close(fd_out[1]);
> ^
> os_unix.c:5140:2: warning: ‘fd_err[1]’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> close(fd_err[1]);
> ^
>
> Closing uninitialized file descriptor is a bug.
>
> fd_out, fd_in and fd_err are only really used when FEAT_CHANNEL
> is defined, so attached patch fixes it by putting them inside
> #ifdef FEAT_CHANNEL.
Thanks.
I wonder if the job feature is much use without the channel feature.
Perhaps we should just have one feature for both. The main reason we
have them is that while still implementing things it didn't work on
Windows.
--
A salesperson says: Translation:
"backward compatible" Old technology
"Premium" Overpriced
"Can't keep it on the shelf" Unavailable
"Stands alone" Piece of shit
"Proprietary" Incompatible
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
