On 2016-03-13, Yegappan Lakshmanan wrote:
> Hi Bram,
>
> On Sun, Mar 13, 2016 at 11:44 AM, Bram Moolenaar wrote:
> >
> > Yegappan Lakshmanan wrote:
> >
> >> >> I am attaching a patch to add the ":cfilter" and ":lfilter" commands to
> >> >> filter entries matching a pattern from the quickfix/location lists.
> >> >> The :cfilter command creates a new quickfix list with entries matching
> >> >> the specified regex pattern. When "!" is supplied, creates a list with
> >> >> entries not matching the pattern.
> >> >
> >> > The help text is very brief. Can you add a useful example?
> >> >
> >>
> >> I have added additional description and examples to the help text.
> >> I have also added tests for the new commands. The updated patch is
> >> attached.
> >
> > Thanks. The help could be a bit more specific about what happens. I
> > guess the new quickfix list is added at the end and becomes the current
> > one. What happens after:
> > :colder 5
> > :cfilter
> >
>
> An updated patch with additional description and tests is attached.
This looks like a great feature. I was unclear, though, about the
meaning of this sentence from the description in :help.
Only the text of the valid entries is used for the match.
While ":help getqflist() refers to the "text" entry as the
"description of the error", ":help errorformat" refers to %m as the
"error message". The latter has been around longer, so I always
think of that portion of the quickfix window contents as the
"message" rather than the "text".
Since the existing :help entries are not consistent, perhaps that
sentence should be changed to something like:
Only the text or error message portion of the valid entries is
used for the match.
Regards,
Gary
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
