On Mon, Apr 4, 2016 at 1:10 AM, Michael Soyka <[email protected]> wrote: > Vim developers, > > Currently the Vim test scripts can only be run using the > testdir/Make_ming.mak makefile. I propose adding a "test" target to > src/Make_cyg_ming.mak to make it possible to run those tests from the "src" > directory. If this is done, the instructions for running these test using > cygwin and mingw would be the same as for unix/linux. > > The diff below shows the proposed changes. It is a block insertion that > should have no side-effects on the existing targets and make variables. I > have included all targets defined in testdir/Make_ming.mak (except I changed > "clean" to "testclean") and so you would have the choice of running these > tests in the same way as before. > > The only issue I see occurs when gvim.exe is to be tested instead of > vim.exe. In that case, the make variable VIMPROG must be defined, otherwise > the test scripts will use vim.exe. Assuming this to be true, one must then > decide how to define it. As I see it, there are two choices: define VIMPROG > on the make command line or use the value of the make variable TARGET. In > the "patch" below, I chose not to use TARGET because that would force the > user to specify "GUI" and perhaps "DEBUG" on the command line. > > Thank you for your attention, > > Michael > > =============================================================== > > $ git diff Make_cyg_ming.mak > diff --git a/src/Make_cyg_ming.mak b/src/Make_cyg_ming.mak > index 62585e9..831731a 100644 > --- a/src/Make_cyg_ming.mak > +++ b/src/Make_cyg_ming.mak > @@ -835,6 +835,23 @@ endif > $(MAKE) -C xxd -f Make_ming.mak clean > > ########################################################################### > +# Execute the test scripts. Run these after compiling Vim, before > installing. > +# > +test: > + cd testdir; \ > + $(MAKE) -f Make_ming.mak VIMPROG=..$(DIRSLASH)$(VIMPROG) vimall > +testclean: > + cd testdir; \ > + $(MAKE) -f Make_ming.mak VIMPROG=..$(DIRSLASH)$(VIMPROG) clean > +benchmark fixff gui nongui small win32: > + cd testdir; \ > + $(MAKE) -f Make_ming.mak VIMPROG=..$(DIRSLASH)$(VIMPROG) $@ > +%.out: > + cd testdir; \ > + $(MAKE) -f Make_ming.mak VIMPROG=..$(DIRSLASH)$(VIMPROG) $@ > + > + > +########################################################################### > INCL = vim.h feature.h os_win32.h os_dos.h ascii.h keymap.h term.h macros.h > \ > structs.h regexp.h option.h ex_cmds.h proto.h globals.h farsi.h \ > gui.h >
Why the separate "cd testdir" at the start of each target? Wouldn't a "-C testdir" argument to $(MAKE), as used in the xxd clean target shown in the top context before the changes, be more elegant? Best regards, Tony. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
