Hi Bram! On Di, 26 Apr 2016, Bram Moolenaar wrote:
> > Christian Brabandt wrote: > > > On Do, 21 Apr 2016, Bram Moolenaar wrote: > > > > > Patch 7.4.1770 > > [...] > > > + /* > > > + * Last attempt. Look in the file "$VIM/rgb.txt". > > > + */ > > > > This part of the code is now in term.c, gui_mac.c, gui_photon.c and > > gui_w32.c Also the color definitions are slightly different between some > > of the GUIs. > > > > Attached is a patch, that simplifies this code a bit. I put the shared > > code into term.c (which most likely is not the correct location). Should > > it be placed into misc2.c perhaps? > > Thanks. I think putting this in term.c is fine. > > It appears rgb.txt is re-read for every color name. Should be much > faster if we read it once and keep the result. Yeah, I noticed that and wondered about it as well. Then I did patch Vim to log whenever it reads rgb.txt and noticed it wasn't read a lot even if switching between many color schemes. Seems like most colorschemes use the #rrggbb notation nowadays, so even when switching colorschemes a lot we one probably won't notice (and therefore I did nothing against it). Best, Christian -- Hallo Thermalbader! -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
