Damien wrote:
> Le Sun, May 01, 2016 at 08:04:12PM -0700, Ken Takata a écrit :
> > Hi Damien,
> >
> > 2016/5/2 Mon 8:55:40 UTC+9 Damien wrote:
> > > Hi LCD and list,
> > >
> > > Please check this patch
> > > https://framagit.org/Damien43/patches/raw/master/vim/perl-5.22.2.patch
> >
> > I haven't try your patch, because ActivePerl/StrawberryPerl 5.22.2 is not
> > released yet. BTW, personally I don't like this part:
> >
> > > @@ -777,7 +784,7 @@ newWINrv(SV *rv, win_T *ptr)
> > > sv_setiv(ptr->w_perl_private, PTR2IV(ptr));
> > > }
> > > else
> > > - SvREFCNT_inc(ptr->w_perl_private);
> > > + SvREFCNT((SV *)ptr->w_perl_private)++;
> > > SvRV(rv) = ptr->w_perl_private;
> > > SvROK_on(rv);
> > > return sv_bless(rv, gv_stashpv("VIWIN", TRUE));
> >
> > Isn't it better to (re)defining SvREFCNT_inc instead of using SvREFCNT()++?
>
> Hi Ken,
>
> Thank for your advice.
>
> I changed for SvREFCNT_inc_void_NN(). It do not need of inline.h
> and are part of public API.
Is this patch now OK to include? I wonder if it now breaks on other
versions of Perl.
--
Beer & pretzels can't be served at the same time in any bar or restaurant.
[real standing law in North Dakota, United States of America]
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
