Yegappan Lakshmanan wrote:
> >> On Sat, May 21, 2016 at 1:12 PM, Yegappan Lakshmanan
> >> <[email protected]> wrote:
> >> > On Fri, May 20, 2016 at 9:17 AM, Bram Moolenaar
> >> > <[email protected]>
> >> > wrote:
> >> >>
> >> >>
> >> >> Justin Keyes wrote:
> >> >>
> >> >> >
> >> >> > ```
> >> >> > Doesn't work for :diffsplit, :diffpatch, :execute and :normal.
> >> >> > ```
> >> >> >
> >> >> > But it doesn't mention user commands. It would avoid a lot of
> >> >> > redundant
> >> >> > commands, and add flexibility, if `:tab` supported user commands.
> >> >> >
> >> >> > Steps to reproduce:
> >> >> >
> >> >> > ```
> >> >> > :command! -nargs=1 Foo split <args>
> >> >> > :tab Foo bar
> >> >> > ```
> >> >> >
> >> >> > - Expected behavior: opens a new buffer named "bar" in a new tab
> >> >> > - Actual behavior: opens a new buffer named "bar" in a new split
> >> >> > window
> >> >>
> >> >> OK, but this will cause trouble if the user command has several Ex
> >> >> commands, then we don't know where to apply the modifier. E.g. when
> >> >> temporarily opening a scratch bufffer.
> >> >>
> >> >> We could make the modifiers available in <> form, so that the user
> >> >> command can apply them where needed. Possibly just <mods>, to pass on
> >> >> all modifiers.
> >> >
> >> >
> >> > The attached patch adds support for the <mods> user command escape
> >> > sequence.
> >>
> >> Updated the patch to also support "<q-mods>".
> >
> > Thanks. This new piece is missing from the help. Would be useful to
> > have an example for this as well.
> >
>
> The help already has the following text that applies to all the escape
> sequences:
>
> -----------------------------------------------
> If the first two characters of an escape sequence are "q-" (for example,
> <q-args>) then the value is quoted in such a way as to make it a valid value
> for use in an expression. This uses the argument as one single value.
> When there is no argument <q-args> is an empty string.
> -----------------------------------------------
>
> So I didn't add additional help text for <q-mods>.
The thing is that the more features we add the more difficult it is to
find the help for something related. Therefore we need to add more
examples and tags. When adding the new feature you are probably aware
of the related stuff, but someone just looking at the help for <mods>
will have a hard time figuring out the <q-mods> variant.
This is not specific for your patch, but since you are making these
changes we should try to make it a bit better.
--
Engineers are widely recognized as superior marriage material: intelligent,
dependable, employed, honest, and handy around the house.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
