Ken Takata wrote:

> 2016/6/22 Wed 6:44:24 UTC+9 Bram Moolenaar wrote:
> > Patch 7.4.1952
> > Problem:    Cscope interface does not support finding assignments.
> > Solution:   Add the "a" command. (ppettina, closes #882)
> > Files:      runtime/doc/if_cscop.txt, src/if_cscope.c
> 
> > --- 1358,1365 ----
> >                    "       g: Find this definition\n"
> >                    "       i: Find files #including this file\n"
> >                    "       s: Find this C symbol\n"
> > !                  "       t: Find this text string\n"
> > !                  "       a: Find assignments to this symbol\n"));
> 
> Isn't it better to sort this message with alphabetical order like the
> following?
> 
> --- a/src/if_cscope.c
> +++ b/src/if_cscope.c
> @@ -1346,17 +1346,17 @@ cs_help(exarg_T *eap UNUSED)
>                                     help, space_cnt, " ",
>                                     cmdp->usage);
>       if (strcmp(cmdp->name, "find") == 0)
>           MSG_PUTS(_("\n"
> +                    "       a: Find assignments to this symbol\n"
>                      "       c: Find functions calling this function\n"
>                      "       d: Find functions called by this function\n"
>                      "       e: Find this egrep pattern\n"
>                      "       f: Find this file\n"
>                      "       g: Find this definition\n"
>                      "       i: Find files #including this file\n"
>                      "       s: Find this C symbol\n"
> -                    "       t: Find this text string\n"
> -                    "       a: Find assignments to this symbol\n"));
> +                    "       t: Find this text string\n"));
>  
>       cmdp++;
>      }
>  
> 
> 
> > --- 70,76 ----
> >       { "add",      cs_add,
> >             N_("Add a new database"),     "add file|dir [pre-path] 
> > [flags]", 0 },
> >       { "find",     cs_find,
> > !           N_("Query for a pattern"),    "find c|d|e|f|g|i|s|t|a name", 1 
> > },
> >       { "help",     cs_help,
> >             N_("Show this message"),      "help", 0 },
> >       { "kill",     cs_kill,
> 
> Maybe this part can be also sorted?
> 
> 
> 
> > --- 126,137 ----
> >     {
> >         const char *query_type[] =
> >         {
> > !           "c", "d", "e", "f", "g", "i", "s", "t", "a", NULL
> >         };
> 
> I'm not sure this part can be sorted, but existing list seems to be sorted.
> Does this affect the logic?

Agreed with all three.  For completion the order doesn't matter, except
that the user probably likes alphabetically better.

-- 
hundred-and-one symptoms of being an internet addict:
203. You're an active member of more than 20 newsgroups.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui