John Marriott wrote:
> On 18-Jul-2016 6:14 AM, Bram Moolenaar wrote:
> > Patch 7.4.2063
> > Problem: eval.c is still too big.
> > Solution: Split off internal functions to evalfunc.c.
> > Files: src/eval.c, src/evalfunc.c, src/list.c, src/proto.h,
> > src/globals.h, src/vim.h, src/proto/eval.pro,
> > src/proto/evalfunc.pro, src/proto/list.pro, src/Makefile,
> > Filelist,
> > src/Make_bc5.mak, src/Make_cyg_ming.mak, src/Make_dice.mak,
> > src/Make_ivc.mak, src/Make_manx.mak, src/Make_morph.mak,
> > src/Make_mvc.mak, src/Make_sas.mak
> >
> I get a warning with this patch (on mingw64):
> gcc -c -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
> -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -pipe -march=n
> ative -Wall -O3 -fomit-frame-pointer -freg-struct-return -s evalfunc.c
> -o objnative/evalfunc.o
> evalfunc.c: In function 'f_foldtext':
> evalfunc.c:3464:16: warning: 'lnum' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> && lnum + 1 < (linenr_T)get_vim_var_nr(VV_FOLDEND))
> ~~~~~^~~
>
> I'm not sure what it should be initialised to.
Should be foldstart. And we should use a for loop.
And sorry for the biggest patch ever. Just had to split up eval.c to
get it down to a reasonable size. I think 10'000 lines is a useful
limit. It seems that coverals has problem with more than that.
--
GUARD #1: What -- a swallow carrying a coconut?
ARTHUR: It could grip it by the husk!
GUARD #1: It's not a question of where he grips it! It's a simple question
of weight ratios! A five ounce bird could not carry a 1 pound
coconut.
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
